diff options
| author | Hans de Goede | 2019-05-21 21:54:12 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2019-05-22 14:32:41 +0200 |
| commit | 99803f17ded0f2193e81cad9deddf318f4c34e4b (patch) | |
| tree | de8ecc98bcf7ca2c831d4450414211a2e2274e8f /drivers/staging/rtl8723bs/os_dep | |
| parent | staging: wilc1000: remove redundant masking of pkt_offset (diff) | |
| download | kernel-qcow2-linux-99803f17ded0f2193e81cad9deddf318f4c34e4b.tar.gz kernel-qcow2-linux-99803f17ded0f2193e81cad9deddf318f4c34e4b.tar.xz kernel-qcow2-linux-99803f17ded0f2193e81cad9deddf318f4c34e4b.zip | |
staging: rtl8723bs: Fix Coverity warning in rtw_dbg_port()
Fix the following Coverity warning:
File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function
rtw_dbg_port():
CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
dead_error_condition: The condition (extra_arg & 7U) > 7U cannot be true.
if ((extra_arg & 0x07) > 0x07)
padapter->driver_ampdu_spacing = 0xFF;
else
padapter->driver_ampdu_spacing = extra_arg;
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rtl8723bs/os_dep')
| -rw-r--r-- | drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index 74a7328b5dd5..bfbbcf0bded3 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -3096,7 +3096,7 @@ static int rtw_dbg_port(struct net_device *dev, DBG_871X("enable driver ctrl ampdu density = %d\n", extra_arg); - if ((extra_arg & 0x07) > 0x07) + if (extra_arg > 0x07) padapter->driver_ampdu_spacing = 0xFF; else padapter->driver_ampdu_spacing = extra_arg; |