summaryrefslogtreecommitdiffstats
path: root/drivers/staging/slicoss
diff options
context:
space:
mode:
authorDevendra Naga2012-08-26 09:06:56 +0200
committerGreg Kroah-Hartman2012-09-04 23:23:33 +0200
commit651d4bc7ed85356efa16465073f13a24f040369e (patch)
tree647ecff33e049388e289c98f8d1b5a1bddc090da /drivers/staging/slicoss
parentstaging: serqt_usb2: fix dbg print when kzalloc failed to allocate qt_port (diff)
downloadkernel-qcow2-linux-651d4bc7ed85356efa16465073f13a24f040369e.tar.gz
kernel-qcow2-linux-651d4bc7ed85356efa16465073f13a24f040369e.tar.xz
kernel-qcow2-linux-651d4bc7ed85356efa16465073f13a24f040369e.zip
staging: slicoss: return early before calling request_firmware with empty firmware filename
when the device id doesn't match in slic_card_download_gbrcv the filename is "", i.e an empty name, and we try calling request_firmware with that name, actually we can just fail out at default case before even calling request_firmware Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/slicoss')
-rw-r--r--drivers/staging/slicoss/slicoss.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 56829fc032ff..eb498b894914 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -514,8 +514,7 @@ static int slic_card_download_gbrcv(struct adapter *adapter)
file = "slicoss/gbrcvucode.sys";
break;
default:
- ASSERT(0);
- break;
+ return -ENOENT;
}
ret = request_firmware(&fw, file, &adapter->pcidev->dev);