diff options
| author | David Kershner | 2017-03-28 15:34:23 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2017-03-29 09:17:02 +0200 |
| commit | 002a5abb23176c0887b438f5b6ee799271a669df (patch) | |
| tree | 4758255ede2ec11fc7160a26bacb92ba66d61314 /drivers/staging/unisys/visorbus/visorchipset.c | |
| parent | staging: unisys: visorbus: add error handling around kobject_uevent (diff) | |
| download | kernel-qcow2-linux-002a5abb23176c0887b438f5b6ee799271a669df.tar.gz kernel-qcow2-linux-002a5abb23176c0887b438f5b6ee799271a669df.tar.xz kernel-qcow2-linux-002a5abb23176c0887b438f5b6ee799271a669df.zip | |
staging: unisys: visorbus: add error handling to toolaction_show
Don't just drop the error from visorchannel_read on the floor, report it.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/unisys/visorbus/visorchipset.c')
| -rw-r--r-- | drivers/staging/unisys/visorbus/visorchipset.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index cb8c6f946c96..543218f11e0a 100644 --- a/drivers/staging/unisys/visorbus/visorchipset.c +++ b/drivers/staging/unisys/visorbus/visorchipset.c @@ -91,10 +91,15 @@ static ssize_t toolaction_show(struct device *dev, char *buf) { u8 tool_action = 0; + int err; + + err = visorchannel_read(chipset_dev->controlvm_channel, + offsetof(struct spar_controlvm_channel_protocol, + tool_action), + &tool_action, sizeof(u8)); + if (err) + return err; - visorchannel_read(chipset_dev->controlvm_channel, - offsetof(struct spar_controlvm_channel_protocol, - tool_action), &tool_action, sizeof(u8)); return sprintf(buf, "%u\n", tool_action); } |