diff options
| author | David Kershner | 2017-03-28 15:34:26 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2017-03-29 09:17:02 +0200 |
| commit | 0d40643672ddb5833b8404397010c3d44515cad0 (patch) | |
| tree | cbf27cc40a95addccd0f54f4d8858ca2ae09c4d9 /drivers/staging/unisys/visorbus/visorchipset.c | |
| parent | staging: unisys: visorbus: add error handling to error_show (diff) | |
| download | kernel-qcow2-linux-0d40643672ddb5833b8404397010c3d44515cad0.tar.gz kernel-qcow2-linux-0d40643672ddb5833b8404397010c3d44515cad0.tar.xz kernel-qcow2-linux-0d40643672ddb5833b8404397010c3d44515cad0.zip | |
staging: unisys: visorbus: add error handling textid_show
Don't just drop the error from visorchannel_read on the floor, report it.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/unisys/visorbus/visorchipset.c')
| -rw-r--r-- | drivers/staging/unisys/visorbus/visorchipset.c | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index b09ef4ce5ae2..cd2f4194ab93 100644 --- a/drivers/staging/unisys/visorbus/visorchipset.c +++ b/drivers/staging/unisys/visorbus/visorchipset.c @@ -205,12 +205,16 @@ static ssize_t textid_show(struct device *dev, struct device_attribute *attr, char *buf) { u32 text_id = 0; + int err; + + err = visorchannel_read + (chipset_dev->controlvm_channel, + offsetof(struct spar_controlvm_channel_protocol, + installation_text_id), + &text_id, sizeof(u32)); + if (err) + return err; - visorchannel_read - (chipset_dev->controlvm_channel, - offsetof(struct spar_controlvm_channel_protocol, - installation_text_id), - &text_id, sizeof(u32)); return sprintf(buf, "%i\n", text_id); } |