diff options
| author | David Kershner | 2016-11-21 18:15:47 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2016-11-23 10:01:57 +0100 |
| commit | 2c4ef563f48e1712e72baf3ccc786a01f540d338 (patch) | |
| tree | 4ad4a845f63798d9e956413b609915ba58f53374 /drivers/staging/unisys/visorbus/visorchipset.c | |
| parent | staging: unisys: visorbus: controlvm_respond add error handling (diff) | |
| download | kernel-qcow2-linux-2c4ef563f48e1712e72baf3ccc786a01f540d338.tar.gz kernel-qcow2-linux-2c4ef563f48e1712e72baf3ccc786a01f540d338.tar.xz kernel-qcow2-linux-2c4ef563f48e1712e72baf3ccc786a01f540d338.zip | |
staging: unisys: visorbus: controlvm_respond_physdev_changestate add error handling
Propagate the error up the stack instead of ignoring it.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/unisys/visorbus/visorchipset.c')
| -rw-r--r-- | drivers/staging/unisys/visorbus/visorchipset.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index 0c454f66beed..e081de32464a 100644 --- a/drivers/staging/unisys/visorbus/visorchipset.c +++ b/drivers/staging/unisys/visorbus/visorchipset.c @@ -561,7 +561,7 @@ controlvm_respond(struct controlvm_message_header *msg_hdr, int response) CONTROLVM_QUEUE_REQUEST, &outmsg); } -static void controlvm_respond_physdev_changestate( +static int controlvm_respond_physdev_changestate( struct controlvm_message_header *msg_hdr, int response, struct spar_segment_state state) { @@ -570,10 +570,8 @@ static void controlvm_respond_physdev_changestate( controlvm_init_response(&outmsg, msg_hdr, response); outmsg.cmd.device_change_state.state = state; outmsg.cmd.device_change_state.flags.phys_device = 1; - if (visorchannel_signalinsert(controlvm_channel, - CONTROLVM_QUEUE_REQUEST, &outmsg)) { - return; - } + return visorchannel_signalinsert(controlvm_channel, + CONTROLVM_QUEUE_REQUEST, &outmsg); } enum crash_obj_type { |