diff options
| author | David Kershner | 2016-11-21 18:15:50 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2016-11-23 10:01:57 +0100 |
| commit | 68f99d4911a06dc2f5af5ad303389b8e01e71d0e (patch) | |
| tree | 8ab0a5267d809b5c94027b00997b7edc0b28b134 /drivers/staging/unisys/visorbus/visorchipset.c | |
| parent | staging: unisys: visorbus: bus_responder add error handling (diff) | |
| download | kernel-qcow2-linux-68f99d4911a06dc2f5af5ad303389b8e01e71d0e.tar.gz kernel-qcow2-linux-68f99d4911a06dc2f5af5ad303389b8e01e71d0e.tar.xz kernel-qcow2-linux-68f99d4911a06dc2f5af5ad303389b8e01e71d0e.zip | |
staging: unisys: visorbus: device_changestate_responder add error handling
Pass the error returned from visorchannel_signalinsert up the stack
instead of just ignoring it.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/unisys/visorbus/visorchipset.c')
| -rw-r--r-- | drivers/staging/unisys/visorbus/visorchipset.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index a10e41aa5d62..f740b52482cd 100644 --- a/drivers/staging/unisys/visorbus/visorchipset.c +++ b/drivers/staging/unisys/visorbus/visorchipset.c @@ -652,7 +652,7 @@ bus_responder(enum controlvm_id cmd_id, return controlvm_respond(pending_msg_hdr, response); } -static void +static int device_changestate_responder(enum controlvm_id cmd_id, struct visor_device *p, int response, struct spar_segment_state response_state) @@ -662,9 +662,9 @@ device_changestate_responder(enum controlvm_id cmd_id, u32 dev_no = p->chipset_dev_no; if (!p->pending_msg_hdr) - return; /* no controlvm response needed */ + return -EIO; if (p->pending_msg_hdr->id != cmd_id) - return; + return -EINVAL; controlvm_init_response(&outmsg, p->pending_msg_hdr, response); @@ -672,9 +672,8 @@ device_changestate_responder(enum controlvm_id cmd_id, outmsg.cmd.device_change_state.dev_no = dev_no; outmsg.cmd.device_change_state.state = response_state; - if (visorchannel_signalinsert(controlvm_channel, - CONTROLVM_QUEUE_REQUEST, &outmsg)) - return; + return visorchannel_signalinsert(controlvm_channel, + CONTROLVM_QUEUE_REQUEST, &outmsg); } static void |