diff options
| author | Stefan Wahren | 2018-04-28 17:47:49 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2018-05-07 04:04:43 +0200 |
| commit | 121bdbf113c70ab7eb1efa94e3c60352a5b81b49 (patch) | |
| tree | fad1b280f04cbccec43fe5b441d495e32a13ead3 /drivers/staging/vc04_services | |
| parent | staging: vchiq_shim: Remove unnecessary break (diff) | |
| download | kernel-qcow2-linux-121bdbf113c70ab7eb1efa94e3c60352a5b81b49.tar.gz kernel-qcow2-linux-121bdbf113c70ab7eb1efa94e3c60352a5b81b49.tar.xz kernel-qcow2-linux-121bdbf113c70ab7eb1efa94e3c60352a5b81b49.zip | |
staging: vc04_services: Remove stack hog issue from TODO
Since there is no vchiq function listed by "make checkstack" anymore,
we can remove the stack hog issue from the TODO.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vc04_services')
| -rw-r--r-- | drivers/staging/vc04_services/interface/vchi/TODO | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/staging/vc04_services/interface/vchi/TODO b/drivers/staging/vc04_services/interface/vchi/TODO index 86708c7c8ec3..0b3ec75ff627 100644 --- a/drivers/staging/vc04_services/interface/vchi/TODO +++ b/drivers/staging/vc04_services/interface/vchi/TODO @@ -40,17 +40,12 @@ should properly handle a module unload. This also includes that all resouces must be freed (kthreads, debugfs entries, ...) and global variables avoided. -5) Fix stack hog - -Running make checkstack shows that vchiq_dump_service_use_state() has -an extensive stack usage. Maybe other functions are also affected. - -6) Cleanup logging mechanism +5) Cleanup logging mechanism The driver should probably be using the standard kernel logging mechanisms such as dev_info, dev_dbg, and friends. -7) Documentation +6) Documentation A short top-down description of this driver's architecture (function of kthreads, userspace, limitations) could be very helpful for reviewers. |