summaryrefslogtreecommitdiffstats
path: root/drivers/staging/vc04_services
diff options
context:
space:
mode:
authorColin Ian King2019-05-31 15:39:26 +0200
committerGreg Kroah-Hartman2019-06-03 14:14:55 +0200
commit313cca245d4b85189b3fc7e75e4fef837b2ed4e2 (patch)
treec8951cb969618b9c1f344d06de1a045d7d56a284 /drivers/staging/vc04_services
parentstaging: kpc2000: removed misc device. (diff)
downloadkernel-qcow2-linux-313cca245d4b85189b3fc7e75e4fef837b2ed4e2.tar.gz
kernel-qcow2-linux-313cca245d4b85189b3fc7e75e4fef837b2ed4e2.tar.xz
kernel-qcow2-linux-313cca245d4b85189b3fc7e75e4fef837b2ed4e2.zip
staging: vc04_services: remove redundant assignment to pointer service
Pointer service is being set to NULL however this value is never read and so the assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vc04_services')
-rw-r--r--drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
index 13910d205fce..17a4f2c8d8b1 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
@@ -639,10 +639,8 @@ int32_t vchi_service_close(const VCHI_SERVICE_HANDLE_T handle)
if (service) {
VCHIQ_STATUS_T status = vchiq_close_service(service->handle);
- if (status == VCHIQ_SUCCESS) {
+ if (status == VCHIQ_SUCCESS)
service_free(service);
- service = NULL;
- }
ret = vchiq_status_to_vchi(status);
}