diff options
| author | Stefan Wahren | 2018-03-31 22:09:37 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2018-04-23 15:47:16 +0200 |
| commit | 8113b89fc615cfb531df0334fb3a091cf6a45ce0 (patch) | |
| tree | 41d6b79493c440685238e9485aa11d75a4624eac /drivers/staging/vc04_services | |
| parent | staging: vboxvideo: Fix line size exceeding 80 columns. (diff) | |
| download | kernel-qcow2-linux-8113b89fc615cfb531df0334fb3a091cf6a45ce0.tar.gz kernel-qcow2-linux-8113b89fc615cfb531df0334fb3a091cf6a45ce0.tar.xz kernel-qcow2-linux-8113b89fc615cfb531df0334fb3a091cf6a45ce0.zip | |
staging: vchiq_core: Fix missing semaphore release in error case
The bail out branch in case of a invalid tx_pos missed a semaphore
release. Dan Carpenter found this with a static checker.
Fixes: d1eab9dec610 ("staging: vchiq_core: Bail out in case of invalid tx_pos")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vc04_services')
| -rw-r--r-- | drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 5d28fff46557..80f6168f06f6 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -601,6 +601,7 @@ reserve_space(VCHIQ_STATE_T *state, size_t space, int is_blocking) } if (tx_pos == (state->slot_queue_available * VCHIQ_SLOT_SIZE)) { + up(&state->slot_available_event); pr_warn("%s: invalid tx_pos: %d\n", __func__, tx_pos); return NULL; } |