diff options
| author | Devendra Naga | 2012-09-06 20:38:06 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2012-09-08 07:07:37 +0200 |
| commit | 960cf81187833ed3f19850551d46377323043876 (patch) | |
| tree | 10c0eeb4b24a7df25d7b6a79f7826e4d9b591ba3 /drivers/staging/vt6655 | |
| parent | staging: vt6655: return ENOMEM rather than ENODEV when alloc_etherdev fail (diff) | |
| download | kernel-qcow2-linux-960cf81187833ed3f19850551d46377323043876.tar.gz kernel-qcow2-linux-960cf81187833ed3f19850551d46377323043876.tar.xz kernel-qcow2-linux-960cf81187833ed3f19850551d46377323043876.zip | |
staging: vt6655: vt6655_init_info function must be void type
this is because it doesn't fail anywhere and returning a value
from it will be completely unnecesary.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vt6655')
| -rw-r--r-- | drivers/staging/vt6655/device_main.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 4ee5f38bb2bf..9e3b3f2bbe53 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -290,7 +290,7 @@ DEFINE_PCI_DEVICE_TABLE(vt6655_pci_id_table) = { static int vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent); -static bool vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, PCHIP_INFO); +static void vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, PCHIP_INFO); static void device_free_info(PSDevice pDevice); static bool device_get_pci_info(PSDevice, struct pci_dev* pcid); static void device_print_info(PSDevice pDevice); @@ -935,9 +935,7 @@ vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent) bFirst=false; } - if (!vt6655_init_info(pcid, &pDevice, pChip_info)) { - return -ENOMEM; - } + vt6655_init_info(pcid, &pDevice, pChip_info); pDevice->dev = dev; pDevice->next_module = root_device_dev; root_device_dev = dev; @@ -1101,7 +1099,7 @@ static void device_print_info(PSDevice pDevice) } -static bool __devinit vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, +static void __devinit vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, PCHIP_INFO pChip_info) { PSDevice p; @@ -1125,8 +1123,6 @@ static bool __devinit vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, (*ppDevice)->multicast_limit =32; spin_lock_init(&((*ppDevice)->lock)); - - return true; } static bool device_get_pci_info(PSDevice pDevice, struct pci_dev* pcid) { |