diff options
| author | Martin Kepplinger | 2014-05-06 07:58:39 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2014-05-15 22:28:16 +0200 |
| commit | ea9a8dae5acca2e2ac0421279de7818e92e4b251 (patch) | |
| tree | 69379d83bdb2fa518c35c254d25f02249bcc98aa /drivers/staging/vt6656/firmware.c | |
| parent | staging: vt6655: fix checkpatch bracing issues (diff) | |
| download | kernel-qcow2-linux-ea9a8dae5acca2e2ac0421279de7818e92e4b251.tar.gz kernel-qcow2-linux-ea9a8dae5acca2e2ac0421279de7818e92e4b251.tar.xz kernel-qcow2-linux-ea9a8dae5acca2e2ac0421279de7818e92e4b251.zip | |
staging: vt6656: make spin_lock_irq() human readable
Don't require FIRMWAREbDownload() to, first off, unlock a held lock.
Thus do all locking in main_usb.c and hold it for a insignificantly
shorter period of time. This makes the affected area significantly more
readable though.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vt6656/firmware.c')
| -rw-r--r-- | drivers/staging/vt6656/firmware.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/vt6656/firmware.c b/drivers/staging/vt6656/firmware.c index 15c1e861c84b..afb79c66a933 100644 --- a/drivers/staging/vt6656/firmware.c +++ b/drivers/staging/vt6656/firmware.c @@ -55,7 +55,6 @@ int FIRMWAREbDownload(struct vnt_private *pDevice) __must_hold(&pDevice->lock) int ii, rc; DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"---->Download firmware\n"); - spin_unlock_irq(&pDevice->lock); rc = request_firmware(&fw, FIRMWARE_NAME, dev); if (rc) { @@ -92,7 +91,6 @@ free_fw: out: kfree(pBuffer); - spin_lock_irq(&pDevice->lock); return result; } MODULE_FIRMWARE(FIRMWARE_NAME); |