summaryrefslogtreecommitdiffstats
path: root/drivers/staging/wilc1000/wilc_wlan.c
diff options
context:
space:
mode:
authorLeo Kim2016-03-15 10:48:13 +0100
committerGreg Kroah-Hartman2016-03-28 16:30:36 +0200
commit5c6021da1c3c46f3c2727626b4a3b9c96bf688ec (patch)
tree9a1f2caf1103386f6399f614c3e4466d55e8b32c /drivers/staging/wilc1000/wilc_wlan.c
parentstaging: wilc1000: changes an ambiguous debug messages (diff)
downloadkernel-qcow2-linux-5c6021da1c3c46f3c2727626b4a3b9c96bf688ec.tar.gz
kernel-qcow2-linux-5c6021da1c3c46f3c2727626b4a3b9c96bf688ec.tar.xz
kernel-qcow2-linux-5c6021da1c3c46f3c2727626b4a3b9c96bf688ec.zip
staging: wilc1000: removes goto definitions from wilc_wlan_firmware_download
This patch removes goto definitions from wilc_wlan_firmware_download function. Goto '_fail_1' feature is error return. It returns error type directly without result variable replacement as well. Signed-off-by: Leo Kim <leo.kim@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/wilc1000/wilc_wlan.c')
-rw-r--r--drivers/staging/wilc1000/wilc_wlan.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
index ca9054a5ff88..ea671a985089 100644
--- a/drivers/staging/wilc1000/wilc_wlan.c
+++ b/drivers/staging/wilc1000/wilc_wlan.c
@@ -946,10 +946,8 @@ int wilc_wlan_firmware_download(struct wilc *wilc, const u8 *buffer,
blksz = BIT(12);
dma_buffer = kmalloc(blksz, GFP_KERNEL);
- if (!dma_buffer) {
- ret = -EIO;
- goto _fail_1;
- }
+ if (!dma_buffer)
+ return -EIO;
offset = 0;
do {
@@ -987,8 +985,6 @@ _fail_:
kfree(dma_buffer);
-_fail_1:
-
return (ret < 0) ? ret : 0;
}