diff options
| author | Peter Huewe | 2013-05-13 23:41:49 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2013-05-17 01:02:35 +0200 |
| commit | 85b38476fde05b4337115f0e830667e7156c6e2e (patch) | |
| tree | 7430c24ce5948b2c166c63cccbad75ac42c1fd44 /drivers/staging/xgifb/vb_setmode.c | |
| parent | staging/xgifb: Remove unnecessary binary calculation in GetXG27FPBits (diff) | |
| download | kernel-qcow2-linux-85b38476fde05b4337115f0e830667e7156c6e2e.tar.gz kernel-qcow2-linux-85b38476fde05b4337115f0e830667e7156c6e2e.tar.xz kernel-qcow2-linux-85b38476fde05b4337115f0e830667e7156c6e2e.zip | |
staging/xgifb: Fix always false condition in vb_setmode.c (smatch)
Smatch complains:
drivers/staging/xgifb/vb_setmode.c:3181
XGI_SetLockRegs() warn: bitwise AND condition is false here
Since SetNTSCTV is defined as 0 in drivers/video/sis/initdef.h this is
correct.
-> Change the condition to == to fix this.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/xgifb/vb_setmode.c')
| -rw-r--r-- | drivers/staging/xgifb/vb_setmode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index 3adec3f18462..5fb699dd1c4c 100644 --- a/drivers/staging/xgifb/vb_setmode.c +++ b/drivers/staging/xgifb/vb_setmode.c @@ -3178,7 +3178,7 @@ static void XGI_SetLockRegs(unsigned short ModeNo, unsigned short ModeIdIndex, if (pVBInfo->VBInfo & SetCRT2ToTV) { if (pVBInfo->TVInfo & TVSimuMode) { if (ModeNo == 0x50) { - if (pVBInfo->TVInfo & SetNTSCTV) { + if (pVBInfo->TVInfo == SetNTSCTV) { xgifb_reg_set(pVBInfo->Part1Port, 0x07, 0x30); xgifb_reg_set(pVBInfo->Part1Port, |