summaryrefslogtreecommitdiffstats
path: root/drivers/staging/zcache
diff options
context:
space:
mode:
authorDan Carpenter2011-08-09 20:01:33 +0200
committerGreg Kroah-Hartman2011-08-23 23:52:20 +0200
commit1dcab0875b113a148b6601d87b4e0e3444440339 (patch)
treedb5db2a6c2c82df642c2a395e37cbe9caaf04044 /drivers/staging/zcache
parentstaging: zcache: fix crash on high memory swap (diff)
downloadkernel-qcow2-linux-1dcab0875b113a148b6601d87b4e0e3444440339.tar.gz
kernel-qcow2-linux-1dcab0875b113a148b6601d87b4e0e3444440339.tar.xz
kernel-qcow2-linux-1dcab0875b113a148b6601d87b4e0e3444440339.zip
Staging: zcache: signedness bug in tmem_get()
"ret" needs to be signed for the error handling to work properly. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/zcache')
-rw-r--r--drivers/staging/zcache/tmem.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/zcache/tmem.c b/drivers/staging/zcache/tmem.c
index 975e34bcd722..1ca66ea9b281 100644
--- a/drivers/staging/zcache/tmem.c
+++ b/drivers/staging/zcache/tmem.c
@@ -604,7 +604,7 @@ int tmem_get(struct tmem_pool *pool, struct tmem_oid *oidp, uint32_t index,
struct tmem_obj *obj;
void *pampd;
bool ephemeral = is_ephemeral(pool);
- uint32_t ret = -1;
+ int ret = -1;
struct tmem_hashbucket *hb;
bool free = (get_and_free == 1) || ((get_and_free == 0) && ephemeral);
bool lock_held = false;