diff options
| author | Johan Hovold | 2015-07-01 12:37:29 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2015-07-02 01:54:44 +0200 |
| commit | 1635304d6384e258d197ca1bc5f2f6418eae28e2 (patch) | |
| tree | 45910f8bde5bcbe2c8926ed791046cd5830774cc /drivers/staging | |
| parent | greybus: operation: remove obsolete operation-field comments (diff) | |
| download | kernel-qcow2-linux-1635304d6384e258d197ca1bc5f2f6418eae28e2.tar.gz kernel-qcow2-linux-1635304d6384e258d197ca1bc5f2f6418eae28e2.tar.xz kernel-qcow2-linux-1635304d6384e258d197ca1bc5f2f6418eae28e2.zip | |
greybus: operation: drop redundant oom message
Drop redundant OOM message, which would already have been logged by the
memory subsystem.
Also remove a FIXME about possibly sending a pre-allocated response,
which is neither possible or desirable. If we ever run out of memory we
have bigger problems then getting a response back to firmware.
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/greybus/operation.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c index b32010ba7bc1..d6e1db87e30a 100644 --- a/drivers/staging/greybus/operation.c +++ b/drivers/staging/greybus/operation.c @@ -673,12 +673,8 @@ static int gb_operation_response_send(struct gb_operation *operation, return 0; if (!operation->response) { - if (!gb_operation_response_alloc(operation, 0)) { - dev_err(&connection->dev, - "error allocating response\n"); - /* XXX Respond with pre-allocated -ENOMEM? */ + if (!gb_operation_response_alloc(operation, 0)) return -ENOMEM; - } } /* Reference will be dropped when message has been sent. */ |