summaryrefslogtreecommitdiffstats
path: root/drivers/target/target_core_pscsi.c
diff options
context:
space:
mode:
authorDan Carpenter2011-11-02 16:48:15 +0100
committerNicholas Bellinger2011-11-02 16:58:47 +0100
commited327ed337a6ee6919ee092c82ac3edeb63bd4de (patch)
treecb9db4d1386aae18a115e2d5de330ecb02d18316 /drivers/target/target_core_pscsi.c
parenttarget: Remove core TRANSPORT_FREE_CMD_INTR usage (diff)
downloadkernel-qcow2-linux-ed327ed337a6ee6919ee092c82ac3edeb63bd4de.tar.gz
kernel-qcow2-linux-ed327ed337a6ee6919ee092c82ac3edeb63bd4de.tar.xz
kernel-qcow2-linux-ed327ed337a6ee6919ee092c82ac3edeb63bd4de.zip
target/pscsi: blk_make_request() returns an ERR_PTR()
The check is wrong here because blk_make_request() returns an ERR_PTR() and it doesn't return NULL. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_pscsi.c')
-rw-r--r--drivers/target/target_core_pscsi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index dad671dee9e9..f941b6232614 100644
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -1091,7 +1091,7 @@ static int pscsi_do_task(struct se_task *task)
req = blk_make_request(pdv->pdv_sd->request_queue, hbio,
GFP_KERNEL);
- if (!req) {
+ if (IS_ERR(req)) {
pr_err("pSCSI: blk_make_request() failed\n");
goto fail;
}