diff options
| author | Martin Svec | 2014-04-01 16:03:02 +0200 |
|---|---|---|
| committer | Nicholas Bellinger | 2014-04-07 10:48:53 +0200 |
| commit | a1e1774c6dfa3a524dd8df51ca95185fe5ef3247 (patch) | |
| tree | fea7c7f70242f729320c22477f661be830bb0be8 /drivers/target/target_core_sbc.c | |
| parent | target/rd: T10-Dif: RAM disk is allocating more space than required. (diff) | |
| download | kernel-qcow2-linux-a1e1774c6dfa3a524dd8df51ca95185fe5ef3247.tar.gz kernel-qcow2-linux-a1e1774c6dfa3a524dd8df51ca95185fe5ef3247.tar.xz kernel-qcow2-linux-a1e1774c6dfa3a524dd8df51ca95185fe5ef3247.zip | |
Target/sbc: Initialize COMPARE_AND_WRITE write_sg scatterlist
When compiled with CONFIG_DEBUG_SG set, uninitialized SGL leads
to BUG() in compare_and_write_callback().
Signed-off-by: Martin Svec <martin.svec@zoner.cz>
Cc: <stable@vger.kernel.org> #3.12+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_sbc.c')
| -rw-r--r-- | drivers/target/target_core_sbc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c index 62daef5c0c8f..ec204f7ef126 100644 --- a/drivers/target/target_core_sbc.c +++ b/drivers/target/target_core_sbc.c @@ -425,13 +425,14 @@ static sense_reason_t compare_and_write_callback(struct se_cmd *cmd) goto out; } - write_sg = kzalloc(sizeof(struct scatterlist) * cmd->t_data_nents, + write_sg = kmalloc(sizeof(struct scatterlist) * cmd->t_data_nents, GFP_KERNEL); if (!write_sg) { pr_err("Unable to allocate compare_and_write sg\n"); ret = TCM_OUT_OF_RESOURCES; goto out; } + sg_init_table(write_sg, cmd->t_data_nents); /* * Setup verify and write data payloads from total NumberLBAs. */ |