diff options
| author | Jörn Engel | 2011-11-24 02:05:51 +0100 |
|---|---|---|
| committer | Nicholas Bellinger | 2011-12-14 12:28:07 +0100 |
| commit | 8359cf43b9dccddeebb0d247146719a14ce6371a (patch) | |
| tree | 25421cb0e06d878709a826edf8d724ca102ab441 /drivers/target/target_core_transport.c | |
| parent | target: simplify target_check_cdb_and_preempt (diff) | |
| download | kernel-qcow2-linux-8359cf43b9dccddeebb0d247146719a14ce6371a.tar.gz kernel-qcow2-linux-8359cf43b9dccddeebb0d247146719a14ce6371a.tar.xz kernel-qcow2-linux-8359cf43b9dccddeebb0d247146719a14ce6371a.zip | |
target: remove useless casts
A reader should spend an extra moment whenever noticing a cast,
because either something special is going on that deserves extra
attention or, as is all too often the case, the code is wrong.
These casts, afaics, have all been useless. They cast a foo* to a
foo*, cast a void* to the assigned type, cast a foo* to void*, before
assigning it to a void* variable, etc.
In a few cases I also removed an additional &...[0], which is equally
useless.
Lastly I added three FIXMEs where, to the best of my judgement, the
code appears to have a bug. It would be good if someone could check
these.
Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_transport.c')
| -rw-r--r-- | drivers/target/target_core_transport.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 511836eb2953..122925686de2 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -4161,7 +4161,7 @@ check_cond: static int transport_clear_lun_thread(void *p) { - struct se_lun *lun = (struct se_lun *)p; + struct se_lun *lun = p; __transport_clear_lun_from_sessions(lun); complete(&lun->lun_shutdown_comp); @@ -4580,7 +4580,7 @@ static int transport_processing_thread(void *param) { int ret; struct se_cmd *cmd; - struct se_device *dev = (struct se_device *) param; + struct se_device *dev = param; while (!kthread_should_stop()) { ret = wait_event_interruptible(dev->dev_queue_obj.thread_wq, |