diff options
| author | Bart Van Assche | 2018-06-22 23:52:58 +0200 |
|---|---|---|
| committer | Martin K. Petersen | 2018-07-02 22:44:31 +0200 |
| commit | edf46eee59c5acd829c3b6a564c26b5386362ea3 (patch) | |
| tree | 890c3b07271518cb35e79977e6f28d917f6fc29b /drivers/target/target_core_transport.c | |
| parent | scsi: target: Simplify transport_generic_free_cmd() (1/2) (diff) | |
| download | kernel-qcow2-linux-edf46eee59c5acd829c3b6a564c26b5386362ea3.tar.gz kernel-qcow2-linux-edf46eee59c5acd829c3b6a564c26b5386362ea3.tar.xz kernel-qcow2-linux-edf46eee59c5acd829c3b6a564c26b5386362ea3.zip | |
scsi: target: Simplify transport_generic_free_cmd() (2/2)
Since target_wait_free_cmd() skips TMFs with no associated LUN, it is safe
to call that function for such commands. Use this to simplify
transport_generic_free_cmd(). The only functional change in this patch is
that CMD_T_FABRIC_STOP gets set for TMFs with no associated LUN by
transport_generic_free_cmd().
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: Mike Christie <mchristi@redhat.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/target/target_core_transport.c')
| -rw-r--r-- | drivers/target/target_core_transport.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 65995532d02b..ebd54fc1f13a 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -2661,12 +2661,10 @@ int transport_generic_free_cmd(struct se_cmd *cmd, int wait_for_tasks) int ret = 0; bool aborted = false, tas = false; - if (!(cmd->se_cmd_flags & SCF_SE_LUN_CMD)) { - if (wait_for_tasks && (cmd->se_cmd_flags & SCF_SCSI_TMR_CDB)) - target_wait_free_cmd(cmd, &aborted, &tas); - } else { - if (wait_for_tasks) - target_wait_free_cmd(cmd, &aborted, &tas); + if (wait_for_tasks) + target_wait_free_cmd(cmd, &aborted, &tas); + + if (cmd->se_cmd_flags & SCF_SE_LUN_CMD) { /* * Handle WRITE failure case where transport_generic_new_cmd() * has already added se_cmd to state_list, but fabric has |