summaryrefslogtreecommitdiffstats
path: root/drivers/usb/core
diff options
context:
space:
mode:
authorSarah Sharp2009-09-08 22:20:16 +0200
committerGreg Kroah-Hartman2009-09-23 15:46:18 +0200
commit6682bb39e111b34290e25c4d275c5bcf8bbccbe1 (patch)
treeb98c9f32ac12fb8c7957d39fd2acc42f8f4ae47e /drivers/usb/core
parentUSB: xhci: Support interrupt transfers. (diff)
downloadkernel-qcow2-linux-6682bb39e111b34290e25c4d275c5bcf8bbccbe1.tar.gz
kernel-qcow2-linux-6682bb39e111b34290e25c4d275c5bcf8bbccbe1.tar.xz
kernel-qcow2-linux-6682bb39e111b34290e25c4d275c5bcf8bbccbe1.zip
USB: Fix SS endpoint companion descriptor parsing.
When there's a descriptor after the SuperSpeed endpoint companion descriptor, the previous code would have skipped over twice the length it was supposed to. This code fixes crashes seen with UASP devices (which have a UASP descriptor after the SS endpoint companion descriptor). Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/core')
-rw-r--r--drivers/usb/core/config.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index a16c538d0132..0d3af6a6ee49 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -105,7 +105,7 @@ static int usb_parse_ss_endpoint_companion(struct device *ddev, int cfgno,
ep->ss_ep_comp->extralen = i;
buffer += i;
size -= i;
- retval = buffer - buffer_start + i;
+ retval = buffer - buffer_start;
if (num_skipped > 0)
dev_dbg(ddev, "skipped %d descriptor%s after %s\n",
num_skipped, plural(num_skipped),