diff options
| author | Zeng Tao | 2018-06-12 16:49:06 +0200 |
|---|---|---|
| committer | Felipe Balbi | 2018-06-18 11:41:01 +0200 |
| commit | 6e967d7e2c4822eba4847ec09037119a0418aaef (patch) | |
| tree | ba223f6454e189162a69d02eb23ee9575e04b377 /drivers/usb/dwc2 | |
| parent | usb: dwc3: of-simple: fix use-after-free on remove (diff) | |
| download | kernel-qcow2-linux-6e967d7e2c4822eba4847ec09037119a0418aaef.tar.gz kernel-qcow2-linux-6e967d7e2c4822eba4847ec09037119a0418aaef.tar.xz kernel-qcow2-linux-6e967d7e2c4822eba4847ec09037119a0418aaef.zip | |
usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak
In ISOC transfer, when the NAK interrupt happens, we shouldn't complete
a usb request, the current flow will complete one usb request with no
hardware transfer, this will lead to a packet drop on the usb bus.
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb/dwc2')
| -rw-r--r-- | drivers/usb/dwc2/gadget.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index bb499fea6100..bb5eb3c8132d 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2818,9 +2818,6 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep) tmp = dwc2_hsotg_read_frameno(hsotg); if (using_desc_dma(hsotg)) { - dwc2_hsotg_complete_request(hsotg, hs_ep, - get_ep_head(hs_ep), 0); - hs_ep->target_frame = tmp; dwc2_gadget_incr_frame_num(hs_ep); dwc2_gadget_start_isoc_ddma(hs_ep); |