summaryrefslogtreecommitdiffstats
path: root/drivers/usb/dwc3/gadget.c
diff options
context:
space:
mode:
authorAnton Tikhomirov2012-02-23 07:38:46 +0100
committerFelipe Balbi2012-03-02 11:12:04 +0100
commit27a78d6a283d6782438f72306746afe4bf44c215 (patch)
treef4b1e2c44e2bed22e593e7071092c272c25ba1e7 /drivers/usb/dwc3/gadget.c
parentusb: dwc3: gadget: don't wrap around the TRB poll on non-ISOC (diff)
downloadkernel-qcow2-linux-27a78d6a283d6782438f72306746afe4bf44c215.tar.gz
kernel-qcow2-linux-27a78d6a283d6782438f72306746afe4bf44c215.tar.xz
kernel-qcow2-linux-27a78d6a283d6782438f72306746afe4bf44c215.zip
usb: dwc3: use proper function for setting endpoint name
It's wrong to use the size of array as an argument for strncat. Memory corruption is possible. strlcat is exactly what we need here. Cc: stable@vger.kernel.org Signed-off-by: Anton Tikhomirov <av.tikhomirov@samsung.com> Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/dwc3/gadget.c')
-rw-r--r--drivers/usb/dwc3/gadget.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 48b2d0d14481..60b75c302aa4 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -643,16 +643,16 @@ static int dwc3_gadget_ep_enable(struct usb_ep *ep,
switch (usb_endpoint_type(desc)) {
case USB_ENDPOINT_XFER_CONTROL:
- strncat(dep->name, "-control", sizeof(dep->name));
+ strlcat(dep->name, "-control", sizeof(dep->name));
break;
case USB_ENDPOINT_XFER_ISOC:
- strncat(dep->name, "-isoc", sizeof(dep->name));
+ strlcat(dep->name, "-isoc", sizeof(dep->name));
break;
case USB_ENDPOINT_XFER_BULK:
- strncat(dep->name, "-bulk", sizeof(dep->name));
+ strlcat(dep->name, "-bulk", sizeof(dep->name));
break;
case USB_ENDPOINT_XFER_INT:
- strncat(dep->name, "-int", sizeof(dep->name));
+ strlcat(dep->name, "-int", sizeof(dep->name));
break;
default:
dev_err(dwc->dev, "invalid endpoint transfer type\n");