diff options
| author | Laurent Pinchart | 2018-08-01 23:14:00 +0200 |
|---|---|---|
| committer | Laurent Pinchart | 2018-09-24 17:54:13 +0200 |
| commit | 86f3daed59bceb4fa7981d85e89f63ebbae1d561 (patch) | |
| tree | 6f506e44cfac3b0c8155120d37987bce03cb6d84 /drivers/usb/gadget/function/uvc_configfs.c | |
| parent | usb: gadget: uvc: configfs: Add section header comments (diff) | |
| download | kernel-qcow2-linux-86f3daed59bceb4fa7981d85e89f63ebbae1d561.tar.gz kernel-qcow2-linux-86f3daed59bceb4fa7981d85e89f63ebbae1d561.tar.xz kernel-qcow2-linux-86f3daed59bceb4fa7981d85e89f63ebbae1d561.zip | |
usb: gadget: uvc: configfs: Drop leaked references to config items
Some of the .allow_link() and .drop_link() operations implementations
call config_group_find_item() and then leak the reference to the
returned item. Fix this by dropping those references where needed.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'drivers/usb/gadget/function/uvc_configfs.c')
| -rw-r--r-- | drivers/usb/gadget/function/uvc_configfs.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/usb/gadget/function/uvc_configfs.c b/drivers/usb/gadget/function/uvc_configfs.c index dbc95c9558de..8d513cc6fb8c 100644 --- a/drivers/usb/gadget/function/uvc_configfs.c +++ b/drivers/usb/gadget/function/uvc_configfs.c @@ -529,6 +529,7 @@ static int uvcg_control_class_allow_link(struct config_item *src, unlock: mutex_unlock(&opts->lock); out: + config_item_put(header); mutex_unlock(su_mutex); return ret; } @@ -564,6 +565,7 @@ static void uvcg_control_class_drop_link(struct config_item *src, unlock: mutex_unlock(&opts->lock); out: + config_item_put(header); mutex_unlock(su_mutex); } @@ -2026,6 +2028,7 @@ static int uvcg_streaming_class_allow_link(struct config_item *src, unlock: mutex_unlock(&opts->lock); out: + config_item_put(header); mutex_unlock(su_mutex); return ret; } @@ -2066,6 +2069,7 @@ static void uvcg_streaming_class_drop_link(struct config_item *src, unlock: mutex_unlock(&opts->lock); out: + config_item_put(header); mutex_unlock(su_mutex); } |