diff options
| author | Steven Robertson | 2010-07-21 22:38:44 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2010-08-10 23:35:41 +0200 |
| commit | 33d973ad88ceb83ed1449592b7574b5b5bb33ac6 (patch) | |
| tree | b2dec9a1718a66c05436fc94fcb646813b99c155 /drivers/usb/mon/mon_bin.c | |
| parent | USB: gadget: functionfs: stale Makefile entry removed (diff) | |
| download | kernel-qcow2-linux-33d973ad88ceb83ed1449592b7574b5b5bb33ac6.tar.gz kernel-qcow2-linux-33d973ad88ceb83ed1449592b7574b5b5bb33ac6.tar.xz kernel-qcow2-linux-33d973ad88ceb83ed1449592b7574b5b5bb33ac6.zip | |
USB: resizing usbmon binary interface buffer causes protection faults
Enlarging the buffer size via the MON_IOCT_RING_SIZE ioctl causes
general protection faults. It appears the culprit is an incorrect
argument to mon_free_buff: instead of passing the size of the current
buffer being freed, the size of the new buffer is passed.
Use the correct size argument to mon_free_buff when changing the size of
the buffer.
Signed-off-by: Steven Robertson <steven@strobe.cc>
Acked-by: Pete Zaitcev <zaitcev@redhat.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/mon/mon_bin.c')
| -rw-r--r-- | drivers/usb/mon/mon_bin.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/mon/mon_bin.c b/drivers/usb/mon/mon_bin.c index 1be0b9f93366..44cb37b5a4dc 100644 --- a/drivers/usb/mon/mon_bin.c +++ b/drivers/usb/mon/mon_bin.c @@ -1004,7 +1004,7 @@ static long mon_bin_ioctl(struct file *file, unsigned int cmd, unsigned long arg mutex_lock(&rp->fetch_lock); spin_lock_irqsave(&rp->b_lock, flags); - mon_free_buff(rp->b_vec, size/CHUNK_SIZE); + mon_free_buff(rp->b_vec, rp->b_size/CHUNK_SIZE); kfree(rp->b_vec); rp->b_vec = vec; rp->b_size = size; |