diff options
| author | Sergei Shtylyov | 2013-06-01 23:50:25 +0200 |
|---|---|---|
| committer | Simon Horman | 2013-06-11 09:10:47 +0200 |
| commit | 725bf9dcafe16aa69c8ab34c63ba36c6eb4492f2 (patch) | |
| tree | 6e55071261b8d7c95233c7df904865bf4427aba3 /drivers/usb/phy | |
| parent | ARM: shmobile: r8a7779: remove USB PHY 2nd memory resource (diff) | |
| download | kernel-qcow2-linux-725bf9dcafe16aa69c8ab34c63ba36c6eb4492f2.tar.gz kernel-qcow2-linux-725bf9dcafe16aa69c8ab34c63ba36c6eb4492f2.tar.xz kernel-qcow2-linux-725bf9dcafe16aa69c8ab34c63ba36c6eb4492f2.zip | |
phy-rcar-usb: correct base address
The memory region that is used by the driver overlaps EHCI and OHCI register
regions for absolutely no reason now -- fix it by adding offset of 0x800 to
the base address, changing the register #define's accordingly. This has extra
positive effect that we now can use devm_ioremap_resource()...
Note that the driver and the SoC code have to be in one patch to keep the code
bisectable...
The patch has been tested on the Marzen board.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Diffstat (limited to 'drivers/usb/phy')
| -rw-r--r-- | drivers/usb/phy/phy-rcar-usb.c | 28 |
1 files changed, 10 insertions, 18 deletions
diff --git a/drivers/usb/phy/phy-rcar-usb.c b/drivers/usb/phy/phy-rcar-usb.c index 4893dbde4ee1..d636cc742e8f 100644 --- a/drivers/usb/phy/phy-rcar-usb.c +++ b/drivers/usb/phy/phy-rcar-usb.c @@ -16,13 +16,13 @@ #include <linux/spinlock.h> #include <linux/module.h> -/* USBH common register */ -#define USBPCTRL0 0x0800 -#define USBPCTRL1 0x0804 -#define USBST 0x0808 -#define USBEH0 0x080C -#define USBOH0 0x081C -#define USBCTL0 0x0858 +/* REGS block */ +#define USBPCTRL0 0x00 +#define USBPCTRL1 0x04 +#define USBST 0x08 +#define USBEH0 0x0C +#define USBOH0 0x1C +#define USBCTL0 0x58 /* USBPCTRL1 */ #define PHY_RST (1 << 2) @@ -139,17 +139,9 @@ static int rcar_usb_phy_probe(struct platform_device *pdev) return -EINVAL; } - /* - * CAUTION - * - * Because this phy address is also mapped under OHCI/EHCI address area, - * this driver can't use devm_request_and_ioremap(dev, res) here - */ - reg0 = devm_ioremap_nocache(dev, res0->start, resource_size(res0)); - if (!reg0) { - dev_err(dev, "ioremap error\n"); - return -ENOMEM; - } + reg0 = devm_ioremap_resource(dev, res0); + if (IS_ERR(reg0)) + return PTR_ERR(reg0); priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) { |