summaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial/garmin_gps.c
diff options
context:
space:
mode:
authorJohan Hovold2013-03-21 12:37:48 +0100
committerGreg Kroah-Hartman2013-03-25 21:54:32 +0100
commit91972724525829a9399a2cb41e60cad853b09229 (patch)
treee6953a141320ef9ffcd8c349385b56bc1e681c71 /drivers/usb/serial/garmin_gps.c
parentUSB: visor: always disable uart on close (diff)
downloadkernel-qcow2-linux-91972724525829a9399a2cb41e60cad853b09229.tar.gz
kernel-qcow2-linux-91972724525829a9399a2cb41e60cad853b09229.tar.xz
kernel-qcow2-linux-91972724525829a9399a2cb41e60cad853b09229.zip
USB: garmin_gps: remove bogus disconnect test in close
Remove bogus disconnect test for serial device being NULL in close. This can never happen as close is guaranteed to be called before the last tty reference is dropped (and port->serial is cleared). Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial/garmin_gps.c')
-rw-r--r--drivers/usb/serial/garmin_gps.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
index 81caf5623ee2..1ade6cf23f7e 100644
--- a/drivers/usb/serial/garmin_gps.c
+++ b/drivers/usb/serial/garmin_gps.c
@@ -946,16 +946,12 @@ static int garmin_open(struct tty_struct *tty, struct usb_serial_port *port)
static void garmin_close(struct usb_serial_port *port)
{
- struct usb_serial *serial = port->serial;
struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
dev_dbg(&port->dev, "%s - port %d - mode=%d state=%d flags=0x%X\n",
__func__, port->number, garmin_data_p->mode,
garmin_data_p->state, garmin_data_p->flags);
- if (!serial)
- return;
-
garmin_clear(garmin_data_p);
/* shutdown our urbs */