diff options
| author | Douglas Anderson | 2018-07-26 22:07:29 +0200 |
|---|---|---|
| committer | Felipe Balbi | 2018-07-30 09:39:19 +0200 |
| commit | 3af0540ad39e0f4935c572ad94f57d5408e95cec (patch) | |
| tree | 9e56d5c150384055ba3de4f2ae33dbcf3a46cbf5 /drivers/usb | |
| parent | usb: dwc2: Turn on uframe_sched on "his" platforms (diff) | |
| download | kernel-qcow2-linux-3af0540ad39e0f4935c572ad94f57d5408e95cec.tar.gz kernel-qcow2-linux-3af0540ad39e0f4935c572ad94f57d5408e95cec.tar.xz kernel-qcow2-linux-3af0540ad39e0f4935c572ad94f57d5408e95cec.zip | |
usb: dwc2: Turn on uframe_sched on "amlogic" platforms
There's no reason to have the uframe scheduler off on dwc2. Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".
The uframe scheduler has been off on Amlogic since commit f94310ac076e
("usb: dwc2: add support for Meson8b and GXBB SoCs"). While this was
after most of the recent improvements, notably the commit 9f9f09b048f5
("usb: dwc2: host: Totally redo the microframe scheduler"), presumably
the parameters were copied from another platform and the uframe
scheduler wasn't tried.
Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.
Reviewed-by: Minas Harutyunyan <hminas@synopsys.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/dwc2/params.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 388c9605602a..3ac84a3837af 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg) p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI; p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 << GAHBCFG_HBSTLEN_SHIFT; - p->uframe_sched = false; } static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg) |