summaryrefslogtreecommitdiffstats
path: root/drivers/usb
diff options
context:
space:
mode:
authorRichard Retanubun2011-03-17 22:39:28 +0100
committerGreg Kroah-Hartman2011-04-14 00:57:19 +0200
commit5808544690300071f09eef9ab83a0fb1f60cf1cd (patch)
tree8fb721b3a6ce9e9ce613c961543a3d3dc92519bf /drivers/usb
parentUSB: fsl_qe_udc: send ZLP when zero flag and length % maxpacket == 0 (diff)
downloadkernel-qcow2-linux-5808544690300071f09eef9ab83a0fb1f60cf1cd.tar.gz
kernel-qcow2-linux-5808544690300071f09eef9ab83a0fb1f60cf1cd.tar.xz
kernel-qcow2-linux-5808544690300071f09eef9ab83a0fb1f60cf1cd.zip
USB: isp1760-hcd: move imask clear after pending work is done
This patch moves the HcInterrupt register write to clear the pending interrupt to after the isr work is done, doing this removes glitches in the irq line. Signed-off-by: Richard Retanubun <richardretanubun@ruggedcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/host/isp1760-hcd.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
index 795345ad45e6..564b03337e7e 100644
--- a/drivers/usb/host/isp1760-hcd.c
+++ b/drivers/usb/host/isp1760-hcd.c
@@ -1676,13 +1676,15 @@ static irqreturn_t isp1760_irq(struct usb_hcd *hcd)
if (unlikely(!imask))
goto leave;
- reg_write32(hcd->regs, HC_INTERRUPT_REG, imask);
if (imask & (HC_ATL_INT | HC_SOT_INT))
do_atl_int(hcd);
if (imask & HC_INTL_INT)
do_intl_int(hcd);
+ /* Clear interrupt mask on device after the work is done */
+ reg_write32(hcd->regs, HC_INTERRUPT_REG, imask);
+
irqret = IRQ_HANDLED;
leave:
spin_unlock(&priv->lock);