diff options
| author | Sebastian Andrzej Siewior | 2014-12-11 18:14:18 +0100 |
|---|---|---|
| committer | Felipe Balbi | 2014-12-22 17:36:24 +0100 |
| commit | 68693b8ea4e284c46bff919ac62bd9ccdfdbb6ba (patch) | |
| tree | a8c9f2d44f57b3d1fd689b2ac6494e7cb55d36cd /drivers/usb | |
| parent | usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop() (diff) | |
| download | kernel-qcow2-linux-68693b8ea4e284c46bff919ac62bd9ccdfdbb6ba.tar.gz kernel-qcow2-linux-68693b8ea4e284c46bff919ac62bd9ccdfdbb6ba.tar.xz kernel-qcow2-linux-68693b8ea4e284c46bff919ac62bd9ccdfdbb6ba.zip | |
usb: musb: stuff leak of struct usb_hcd
since the split of host+gadget mode in commit 74c2e9360058 ("usb: musb:
factor out hcd initalization") we leak the usb_hcd struct. We call now
musb_host_cleanup() which does basically usb_remove_hcd() and also sets
the hcd variable to NULL. Doing so makes the finall call to
musb_host_free() basically a nop and the usb_hcd remains around for ever
without anowner.
This patch drops that NULL assignment for that reason.
Fixes: 74c2e9360058 ("usb: musb: factor out hcd initalization")
Cc: <stable@vger.kernel.org> # v3.11+
Cc: Daniel Mack <zonque@gmail.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/musb/musb_host.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index 23d474d3d7f4..883a9adfdfff 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -2663,7 +2663,6 @@ void musb_host_cleanup(struct musb *musb) if (musb->port_mode == MUSB_PORT_MODE_GADGET) return; usb_remove_hcd(musb->hcd); - musb->hcd = NULL; } void musb_host_free(struct musb *musb) |