diff options
| author | Stephen Warren | 2017-08-16 22:30:10 +0200 |
|---|---|---|
| committer | Felipe Balbi | 2017-08-18 11:28:50 +0200 |
| commit | daa35bd95634a2a2d72d1049c93576a02711cb1a (patch) | |
| tree | 04d8f8adbdd1f976d3d42250b12fe4eeff1deebf /drivers/usb | |
| parent | USB: Gadget core: fix inconsistency in the interface tousb_add_gadget_udc_rel... (diff) | |
| download | kernel-qcow2-linux-daa35bd95634a2a2d72d1049c93576a02711cb1a.tar.gz kernel-qcow2-linux-daa35bd95634a2a2d72d1049c93576a02711cb1a.tar.xz kernel-qcow2-linux-daa35bd95634a2a2d72d1049c93576a02711cb1a.zip | |
usb: gadget: serial: fix oops when data rx'd after close
When the gadget serial device has no associated TTY, do not pass any
received data into the TTY layer for processing; simply drop it instead.
This prevents the TTY layer from calling back into the gadget serial
driver, which will then crash in e.g. gs_write_room() due to lack of
gadget serial device to TTY association (i.e. a NULL pointer dereference).
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/gadget/function/u_serial.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c index 9b0805f55ad7..4176216d54be 100644 --- a/drivers/usb/gadget/function/u_serial.c +++ b/drivers/usb/gadget/function/u_serial.c @@ -537,7 +537,7 @@ static void gs_rx_push(unsigned long _port) } /* push data to (open) tty */ - if (req->actual) { + if (req->actual && tty) { char *packet = req->buf; unsigned size = req->actual; unsigned n; |