diff options
| author | Orjan Friberg | 2006-08-09 08:31:40 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2006-08-11 23:06:06 +0200 |
| commit | f54fa84dda211f68f65002efa44142207c886c79 (patch) | |
| tree | 117113e866346afa5737a78ba3ba2085b059aab1 /drivers/usb | |
| parent | USB: ftdi_sio driver - new PIDs (diff) | |
| download | kernel-qcow2-linux-f54fa84dda211f68f65002efa44142207c886c79.tar.gz kernel-qcow2-linux-f54fa84dda211f68f65002efa44142207c886c79.tar.xz kernel-qcow2-linux-f54fa84dda211f68f65002efa44142207c886c79.zip | |
USB: usbtest.c: unsigned retval makes ctrl_out return 0 in case of error
In my quest to try and figure out why test 14 (control write) doesn't
work with my EZ-USB board, I noticed that sometimes testusb reported
no error even though the kernel log complained "byte 0 is 0 not 2" etc.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/misc/usbtest.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c index 786e1dbe88ec..983e104dd452 100644 --- a/drivers/usb/misc/usbtest.c +++ b/drivers/usb/misc/usbtest.c @@ -1242,11 +1242,12 @@ done: static int ctrl_out (struct usbtest_dev *dev, unsigned count, unsigned length, unsigned vary) { - unsigned i, j, len, retval; + unsigned i, j, len; + int retval; u8 *buf; char *what = "?"; struct usb_device *udev; - + if (length < 1 || length > 0xffff || vary >= length) return -EINVAL; |