diff options
| author | Florian Tobias Schandinat | 2009-09-23 01:47:28 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2009-09-23 16:39:53 +0200 |
| commit | 5016af53ebbd1450c2656c94dfbd1dad15c19f60 (patch) | |
| tree | 96c6ec0f311d0ce8ff5b0b2e963814dd12632e71 /drivers/video/via/global.c | |
| parent | viafb: switch to seq_file (diff) | |
| download | kernel-qcow2-linux-5016af53ebbd1450c2656c94dfbd1dad15c19f60.tar.gz kernel-qcow2-linux-5016af53ebbd1450c2656c94dfbd1dad15c19f60.tar.xz kernel-qcow2-linux-5016af53ebbd1450c2656c94dfbd1dad15c19f60.zip | |
viafb: cleanup viafb_cursor
Clean the hardware cursor handling up.
The most notable change is that it no longer buffers the values in
viacursor but uses the ones in cursor instead as they are guaranteed to be
always valid.
Furthermore it uses local instead global variables where possible, moves
the cursor variable in shared as only one hardware cursor is supported and
returns an error if memory allocation fails. Last but not least it fixes
a too small buffer (as u32 has only 4 and not 32 bytes) but this did not
produce any known problems.
This is mostly a code cleanup, no negative runtime changes are expected.
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Scott Fang <ScottFang@viatech.com.cn>
Cc: Joseph Chan <JosephChan@via.com.tw>
Cc: Harald Welte <laforge@gnumonks.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video/via/global.c')
| -rw-r--r-- | drivers/video/via/global.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/video/via/global.c b/drivers/video/via/global.c index 1096fd5de2bf..33e7c45b2b78 100644 --- a/drivers/video/via/global.c +++ b/drivers/video/via/global.c @@ -51,7 +51,6 @@ unsigned int viafb_second_yres = 480; unsigned int viafb_second_virtual_xres; unsigned int viafb_second_virtual_yres; int viafb_lcd_panel_id = LCD_PANEL_ID_MAXIMUM + 1; -struct fb_cursor viacursor; struct fb_info *viafbinfo; struct fb_info *viafbinfo1; struct viafb_par *viaparinfo; |