diff options
| author | Florian Tobias Schandinat | 2010-07-23 13:32:25 +0200 |
|---|---|---|
| committer | Florian Tobias Schandinat | 2010-07-23 16:46:11 +0200 |
| commit | af29a5b1781bf642a29b5e9bb6162dccfcd626df (patch) | |
| tree | 71620cfea61cefeb502149a6c61e1937b4d31dfc /drivers/video | |
| parent | viafb: probe cleanups (diff) | |
| download | kernel-qcow2-linux-af29a5b1781bf642a29b5e9bb6162dccfcd626df.tar.gz kernel-qcow2-linux-af29a5b1781bf642a29b5e9bb6162dccfcd626df.tar.xz kernel-qcow2-linux-af29a5b1781bf642a29b5e9bb6162dccfcd626df.zip | |
viafb: fix accel_flags check_var bug
viafb: fix accel_flags check_var bug
In check_var we should check and modify the var given and not the
one which is currently active. So this code was obviously wrong.
Probably this was doing no harm because all acceleration functions
also check whether acceleration is possible. (otherwise I would
expect this to lead to a null pointer dereference)
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Joseph Chan <JosephChan@via.com.tw>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/via/viafbdev.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/video/via/viafbdev.c b/drivers/video/via/viafbdev.c index 0f56eb28227d..bdd0e4130f4e 100644 --- a/drivers/video/via/viafbdev.c +++ b/drivers/video/via/viafbdev.c @@ -216,9 +216,9 @@ static int viafb_check_var(struct fb_var_screeninfo *var, /* Adjust var according to our driver's own table */ viafb_fill_var_timing_info(var, viafb_refresh, vmode_entry); - if (info->var.accel_flags & FB_ACCELF_TEXT && + if (var->accel_flags & FB_ACCELF_TEXT && !ppar->shared->vdev->engine_mmio) - info->var.accel_flags = 0; + var->accel_flags = 0; return 0; } |