summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorJeff Garzik2007-09-21 13:54:49 +0200
committerJeff Garzik2007-10-12 20:55:40 +0200
commit24f756866676b40446e361c1f87738707161da93 (patch)
tree2709ec5b4bb5f0e9c980621e7a1a2b97bdcd7a93 /drivers
parent[libata] SCSI: improve FORMAT UNIT; minor code cleanups (diff)
downloadkernel-qcow2-linux-24f756866676b40446e361c1f87738707161da93.tar.gz
kernel-qcow2-linux-24f756866676b40446e361c1f87738707161da93.tar.xz
kernel-qcow2-linux-24f756866676b40446e361c1f87738707161da93.zip
[libata] SCSI: clean up R/W recovery mode page
Clear ARRE, we don't do auto-reallocation on reads, just on writes. Also, hardcode the size of the array using RW_RECOVERY_MPAGE_LEN, following the style of the surrounding code. Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/ata/libata-scsi.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 553488015e49..d482b589a18a 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -71,11 +71,10 @@ static int ata_scsi_user_scan(struct Scsi_Host *shost, unsigned int channel,
#define ALL_SUB_MPAGES 0xff
-static const u8 def_rw_recovery_mpage[] = {
+static const u8 def_rw_recovery_mpage[RW_RECOVERY_MPAGE_LEN] = {
RW_RECOVERY_MPAGE,
RW_RECOVERY_MPAGE_LEN - 2,
- (1 << 7) | /* AWRE, sat-r06 say it shall be 0 */
- (1 << 6), /* ARRE (auto read reallocation) */
+ (1 << 7), /* AWRE */
0, /* read retry count */
0, 0, 0, 0,
0, /* write retry count */