diff options
| author | Sebastian Andrzej Siewior | 2013-10-16 12:50:07 +0200 |
|---|---|---|
| committer | Felipe Balbi | 2013-10-17 18:31:51 +0200 |
| commit | 8d1aad7485e653c2c5fd985b326096f680f7d918 (patch) | |
| tree | 67db34c0f82fcfe41f433ffc34f7f51d4015b36b /drivers | |
| parent | usb: musb: core: properly free host / device structs in err path (diff) | |
| download | kernel-qcow2-linux-8d1aad7485e653c2c5fd985b326096f680f7d918.tar.gz kernel-qcow2-linux-8d1aad7485e653c2c5fd985b326096f680f7d918.tar.xz kernel-qcow2-linux-8d1aad7485e653c2c5fd985b326096f680f7d918.zip | |
usb: musb: core: Call dma_controller_destroy() in error path only once.
In commit f3ce4d5 ("usb: musb: core: call dma_controller_destroy() in the err path")
I erroneously assumed that the dma controller is not removed in the
error patch. This was wrong because it happens later via musb_free().
That means the original commit can be reverted because it is wrong or we
do this, so it is more obvious.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/musb/musb_core.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 6203ad38e913..7fd213785d52 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c @@ -1764,8 +1764,6 @@ static void musb_free(struct musb *musb) free_irq(musb->nIrq, musb); } cancel_work_sync(&musb->irq_work); - if (musb->dma_controller) - dma_controller_destroy(musb->dma_controller); musb_host_free(musb); } @@ -1990,6 +1988,9 @@ static int musb_remove(struct platform_device *pdev) musb_exit_debugfs(musb); musb_shutdown(pdev); + if (musb->dma_controller) + dma_controller_destroy(musb->dma_controller); + musb_free(musb); device_init_wakeup(dev, 0); return 0; |