diff options
| author | Jan Engelhardt | 2007-05-27 23:48:54 +0200 |
|---|---|---|
| committer | David S. Miller | 2007-05-29 11:50:07 +0200 |
| commit | b00ccd0f0b3fe8776aead63ec96313e84451b337 (patch) | |
| tree | 5c5935b46544ab7d639d2e986cb230777f1e8a47 /drivers | |
| parent | [SPARC64]: arch/sparc64/time.c doesn't compile on Ultra 1 (no PCI) (diff) | |
| download | kernel-qcow2-linux-b00ccd0f0b3fe8776aead63ec96313e84451b337.tar.gz kernel-qcow2-linux-b00ccd0f0b3fe8776aead63ec96313e84451b337.tar.xz kernel-qcow2-linux-b00ccd0f0b3fe8776aead63ec96313e84451b337.zip | |
[SPARC]: Linux always started with 9600 8N1
The Linux kernel ignored the PROM's serial settings (115200,n,8,1 in
my case). This was because mode_prop remained "ttyX-mode" (expected:
"ttya-mode") due to the constness of string literals when used with
"char *". Since there is no "ttyX-mode" property in the PROM, Linux
always used the default 9600.
[ Investigation of the suncore.s assembler reveals that gcc optimizied
away the stores, yet did not emit a warning, which is a pretty
anti-social thing to do and is the only reason this bug lived for
so long -DaveM ]
Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/serial/suncore.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/serial/suncore.c b/drivers/serial/suncore.c index e35d9ab359f1..b45ba5392dd3 100644 --- a/drivers/serial/suncore.c +++ b/drivers/serial/suncore.c @@ -30,9 +30,9 @@ void sunserial_console_termios(struct console *con) { char mode[16], buf[16], *s; - char *mode_prop = "ttyX-mode"; - char *cd_prop = "ttyX-ignore-cd"; - char *dtr_prop = "ttyX-rts-dtr-off"; + char mode_prop[] = "ttyX-mode"; + char cd_prop[] = "ttyX-ignore-cd"; + char dtr_prop[] = "ttyX-rts-dtr-off"; char *ssp_console_modes_prop = "ssp-console-modes"; int baud, bits, stop, cflag; char parity; |