diff options
| author | Gustavo A. R. Silva | 2019-01-10 22:52:25 +0100 |
|---|---|---|
| committer | Gustavo A. R. Silva | 2019-04-09 01:35:56 +0200 |
| commit | e690c9e3f4fb2cc589414c5bf502dcfe04e685de (patch) | |
| tree | 2dfca439baaf49dd2db944d0b9edbf4197a7ffa6 /fs/afs/flock.c | |
| parent | fs: mark expected switch fall-throughs (diff) | |
| download | kernel-qcow2-linux-e690c9e3f4fb2cc589414c5bf502dcfe04e685de.tar.gz kernel-qcow2-linux-e690c9e3f4fb2cc589414c5bf502dcfe04e685de.tar.xz kernel-qcow2-linux-e690c9e3f4fb2cc589414c5bf502dcfe04e685de.zip | |
afs: Mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in many cases I placed a /* Fall through */ comment
at the bottom of the case, which what GCC is expecting to find.
In other cases I had to tweak a bit the format of the comments.
This patch suppresses ALL missing-break-in-switch false positives
in fs/afs
Addresses-Coverity-ID: 115042 ("Missing break in switch")
Addresses-Coverity-ID: 115043 ("Missing break in switch")
Addresses-Coverity-ID: 115045 ("Missing break in switch")
Addresses-Coverity-ID: 1357430 ("Missing break in switch")
Addresses-Coverity-ID: 115047 ("Missing break in switch")
Addresses-Coverity-ID: 115050 ("Missing break in switch")
Addresses-Coverity-ID: 115051 ("Missing break in switch")
Addresses-Coverity-ID: 1467806 ("Missing break in switch")
Addresses-Coverity-ID: 1467807 ("Missing break in switch")
Addresses-Coverity-ID: 1467811 ("Missing break in switch")
Addresses-Coverity-ID: 115041 ("Missing break in switch")
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Diffstat (limited to 'fs/afs/flock.c')
| -rw-r--r-- | fs/afs/flock.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/afs/flock.c b/fs/afs/flock.c index e432bd27a2e7..6a0174258382 100644 --- a/fs/afs/flock.c +++ b/fs/afs/flock.c @@ -303,6 +303,7 @@ again: return; } + /* Fall through */ default: /* Looks like a lock request was withdrawn. */ spin_unlock(&vnode->lock); |