diff options
| author | Ian Kent | 2016-11-23 22:03:42 +0100 |
|---|---|---|
| committer | Al Viro | 2016-12-04 02:51:49 +0100 |
| commit | 60359741473438f66fef7297d1fa2435640dbe79 (patch) | |
| tree | 3316c740550e8bd1ddc441385517e28d96e5468e /fs/autofs4/dev-ioctl.c | |
| parent | autofs: use path_is_mountpoint() to fix unreliable d_mountpoint() checks (diff) | |
| download | kernel-qcow2-linux-60359741473438f66fef7297d1fa2435640dbe79.tar.gz kernel-qcow2-linux-60359741473438f66fef7297d1fa2435640dbe79.tar.xz kernel-qcow2-linux-60359741473438f66fef7297d1fa2435640dbe79.zip | |
autofs: use path_has_submounts() to fix unreliable have_submount() checks
If an automount mount is clone(2)ed into a file system that is propagation
private, when it later expires in the originating namespace, subsequent
calls to autofs ->d_automount() for that dentry in the original namespace
will return ELOOP until the mount is umounted in the cloned namespace.
Now that a struct path is available where needed use path_has_submounts()
instead of have_submounts() so we don't get false positives when checking
if a dentry is a mount point or contains mounts in the current namespace.
Link: http://lkml.kernel.org/r/20161011053423.27645.91233.stgit@pluto.themaw.net
Signed-off-by: Ian Kent <raven@themaw.net>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Omar Sandoval <osandov@osandov.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/autofs4/dev-ioctl.c')
| -rw-r--r-- | fs/autofs4/dev-ioctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c index 40c69f91dc0a..afacdaa8dd5a 100644 --- a/fs/autofs4/dev-ioctl.c +++ b/fs/autofs4/dev-ioctl.c @@ -575,7 +575,7 @@ static int autofs_dev_ioctl_ismountpoint(struct file *fp, devid = new_encode_dev(dev); - err = have_submounts(path.dentry); + err = path_has_submounts(&path); if (follow_down_one(&path)) magic = path.dentry->d_sb->s_magic; |