diff options
| author | Nikolay Borisov | 2018-09-13 10:35:10 +0200 |
|---|---|---|
| committer | David Sterba | 2018-10-15 17:23:31 +0200 |
| commit | 315bed43fea532650933e7bba316a7601d439edf (patch) | |
| tree | ffeeaefa9373a653a6c4dfc4d71a4b4beca5661f /fs/btrfs/ctree.c | |
| parent | btrfs: Remove logically dead code from btrfs_orphan_cleanup (diff) | |
| download | kernel-qcow2-linux-315bed43fea532650933e7bba316a7601d439edf.tar.gz kernel-qcow2-linux-315bed43fea532650933e7bba316a7601d439edf.tar.xz kernel-qcow2-linux-315bed43fea532650933e7bba316a7601d439edf.zip | |
btrfs: handle error of get_old_root
In btrfs_search_old_slot get_old_root is always used with the assumption
it cannot fail. However, this is not true in rare circumstance it can
fail and return null. This will lead to null point dereference when the
header is read. Fix this by checking the return value and properly
handling NULL by setting ret to -EIO and returning gracefully.
Coverity-id: 1087503
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/ctree.c')
| -rw-r--r-- | fs/btrfs/ctree.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 6178fadf80a1..0a6c645fab0a 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -2960,6 +2960,10 @@ int btrfs_search_old_slot(struct btrfs_root *root, const struct btrfs_key *key, again: b = get_old_root(root, time_seq); + if (!b) { + ret = -EIO; + goto done; + } level = btrfs_header_level(b); p->locks[level] = BTRFS_READ_LOCK; |