summaryrefslogtreecommitdiffstats
path: root/fs/btrfs/ctree.c
diff options
context:
space:
mode:
authorLiu Bo2018-05-18 05:00:24 +0200
committerDavid Sterba2018-05-30 16:46:51 +0200
commitd80bb3f905ccf70b2c4dde541cff7286e6f936e8 (patch)
tree52dae8e835ae9a714694e5154f4c2ff3fd9c2640 /fs/btrfs/ctree.c
parentBtrfs: grab write lock directly if write_lock_level is the max level (diff)
downloadkernel-qcow2-linux-d80bb3f905ccf70b2c4dde541cff7286e6f936e8.tar.gz
kernel-qcow2-linux-d80bb3f905ccf70b2c4dde541cff7286e6f936e8.tar.xz
kernel-qcow2-linux-d80bb3f905ccf70b2c4dde541cff7286e6f936e8.zip
Btrfs: remove always true check in unlock_up
As unlock_up() is written as for () { if (!path->locks[i]) break; ... if (... && path->locks[i]) { } } Apparently, @path->locks[i] is always true at this 'if'. Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com> Reviewed-by: David Sterba <dsterba@suse.com> Reviewed-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/ctree.c')
-rw-r--r--fs/btrfs/ctree.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index 239682330929..973912ec8992 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -2330,7 +2330,7 @@ static noinline void unlock_up(struct btrfs_path *path, int level,
no_skips = 1;
t = path->nodes[i];
- if (i >= lowest_unlock && i > skip_level && path->locks[i]) {
+ if (i >= lowest_unlock && i > skip_level) {
btrfs_tree_unlock_rw(t, path->locks[i]);
path->locks[i] = 0;
if (write_lock_level &&