diff options
| author | Jeff Mahoney | 2011-10-04 05:22:41 +0200 |
|---|---|---|
| committer | David Sterba | 2012-03-22 01:45:36 +0100 |
| commit | 2c536799f1bde905bbacf7af3aa6be3f4de66005 (patch) | |
| tree | 54f306bf4320d97e73f9728268a99910b234d048 /fs/btrfs/ctree.h | |
| parent | btrfs: split extent_state ops (diff) | |
| download | kernel-qcow2-linux-2c536799f1bde905bbacf7af3aa6be3f4de66005.tar.gz kernel-qcow2-linux-2c536799f1bde905bbacf7af3aa6be3f4de66005.tar.xz kernel-qcow2-linux-2c536799f1bde905bbacf7af3aa6be3f4de66005.zip | |
btrfs: btrfs_drop_snapshot should return int
Commit cb1b69f4 (Btrfs: forced readonly when btrfs_drop_snapshot() fails)
made btrfs_drop_snapshot return void because there were no callers checking
the return value. That is the wrong order to handle error propogation since
the caller will have no idea that an error has occured and continue on
as if nothing went wrong.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Diffstat (limited to 'fs/btrfs/ctree.h')
| -rw-r--r-- | fs/btrfs/ctree.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 30c5a247ab2b..f6bca05a4b4c 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -2661,9 +2661,9 @@ static inline int btrfs_next_item(struct btrfs_root *root, struct btrfs_path *p) } int btrfs_prev_leaf(struct btrfs_root *root, struct btrfs_path *path); int btrfs_leaf_free_space(struct btrfs_root *root, struct extent_buffer *leaf); -void btrfs_drop_snapshot(struct btrfs_root *root, - struct btrfs_block_rsv *block_rsv, int update_ref, - int for_reloc); +int __must_check btrfs_drop_snapshot(struct btrfs_root *root, + struct btrfs_block_rsv *block_rsv, + int update_ref, int for_reloc); int btrfs_drop_subtree(struct btrfs_trans_handle *trans, struct btrfs_root *root, struct extent_buffer *node, |