diff options
| author | Elena Reshetova | 2017-03-03 09:55:10 +0100 |
|---|---|---|
| committer | David Sterba | 2017-04-18 14:07:23 +0200 |
| commit | 140475ae4ad10d140bb69572499b1ff87367e807 (patch) | |
| tree | 030cedc7593bdcfab1149239a77010427afe48bf /fs/btrfs/volumes.c | |
| parent | Btrfs: remove ASSERT in btrfs_truncate_inode_items (diff) | |
| download | kernel-qcow2-linux-140475ae4ad10d140bb69572499b1ff87367e807.tar.gz kernel-qcow2-linux-140475ae4ad10d140bb69572499b1ff87367e807.tar.xz kernel-qcow2-linux-140475ae4ad10d140bb69572499b1ff87367e807.zip | |
btrfs: convert btrfs_bio.refs from atomic_t to refcount_t
refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David Windsor <dwindsor@gmail.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/volumes.c')
| -rw-r--r-- | fs/btrfs/volumes.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 02bbc4c8c755..0f6706047167 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -5301,22 +5301,22 @@ static struct btrfs_bio *alloc_btrfs_bio(int total_stripes, int real_stripes) GFP_NOFS|__GFP_NOFAIL); atomic_set(&bbio->error, 0); - atomic_set(&bbio->refs, 1); + refcount_set(&bbio->refs, 1); return bbio; } void btrfs_get_bbio(struct btrfs_bio *bbio) { - WARN_ON(!atomic_read(&bbio->refs)); - atomic_inc(&bbio->refs); + WARN_ON(!refcount_read(&bbio->refs)); + refcount_inc(&bbio->refs); } void btrfs_put_bbio(struct btrfs_bio *bbio) { if (!bbio) return; - if (atomic_dec_and_test(&bbio->refs)) + if (refcount_dec_and_test(&bbio->refs)) kfree(bbio); } |