diff options
| author | Liu Bo | 2017-03-29 19:55:16 +0200 |
|---|---|---|
| committer | David Sterba | 2017-04-18 14:07:26 +0200 |
| commit | 1bcd7aa17fc1fa29009feec3e0ac4230d0d9f700 (patch) | |
| tree | 0c0ffcaf4449e85de8714d177d7615dfc4e91045 /fs/btrfs | |
| parent | btrfs: track exclusive filesystem operation in flags (diff) | |
| download | kernel-qcow2-linux-1bcd7aa17fc1fa29009feec3e0ac4230d0d9f700.tar.gz kernel-qcow2-linux-1bcd7aa17fc1fa29009feec3e0ac4230d0d9f700.tar.xz kernel-qcow2-linux-1bcd7aa17fc1fa29009feec3e0ac4230d0d9f700.zip | |
Btrfs: set scrub page's io_error if failing to submit io
Scrub repairs data by the unit called scrub_block, which may contain
several pages. Scrub always tries to look up a good copy of a whole
block, but if there's no such copy, it tries to do repair page by page.
If we don't set page's io_error when checking this bad copy, in the last
step, we may skip this page when repairing bad copy from good copy.
Cc: David Sterba <dsterba@suse.cz>
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/scrub.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index 6ba0c9ddf777..f499ed782671 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -1497,14 +1497,18 @@ static void scrub_recheck_block(struct btrfs_fs_info *fs_info, bio_add_page(bio, page->page, PAGE_SIZE, 0); if (!retry_failed_mirror && scrub_is_page_on_raid56(page)) { - if (scrub_submit_raid56_bio_wait(fs_info, bio, page)) + if (scrub_submit_raid56_bio_wait(fs_info, bio, page)) { + page->io_error = 1; sblock->no_io_error_seen = 0; + } } else { bio->bi_iter.bi_sector = page->physical >> 9; bio_set_op_attrs(bio, REQ_OP_READ, 0); - if (btrfsic_submit_bio_wait(bio)) + if (btrfsic_submit_bio_wait(bio)) { + page->io_error = 1; sblock->no_io_error_seen = 0; + } } bio_put(bio); |