summaryrefslogtreecommitdiffstats
path: root/fs/char_dev.c
diff options
context:
space:
mode:
authorRoland Dreier2006-07-14 09:24:23 +0200
committerLinus Torvalds2006-07-15 06:53:54 +0200
commitc259cc281255bdb30ceba190bfd7f37e3ae3fc85 (patch)
tree395028450ca91c441eab243186f5015fe5d6e3d4 /fs/char_dev.c
parent[PATCH] reiserfs: fix handling of device names with /'s in them (diff)
downloadkernel-qcow2-linux-c259cc281255bdb30ceba190bfd7f37e3ae3fc85.tar.gz
kernel-qcow2-linux-c259cc281255bdb30ceba190bfd7f37e3ae3fc85.tar.xz
kernel-qcow2-linux-c259cc281255bdb30ceba190bfd7f37e3ae3fc85.zip
[PATCH] Convert idr's internal locking to _irqsave variant
Currently, the code in lib/idr.c uses a bare spin_lock(&idp->lock) to do internal locking. This is a nasty trap for code that might call idr functions from different contexts; for example, it seems perfectly reasonable to call idr_get_new() from process context and idr_remove() from interrupt context -- but with the current locking this would lead to a potential deadlock. The simplest fix for this is to just convert the idr locking to use spin_lock_irqsave(). In particular, this fixes a very complicated locking issue detected by lockdep, involving the ib_ipoib driver's priv->lock and dev->_xmit_lock, which get involved with the ib_sa module's query_idr.lock. Cc: Arjan van de Ven <arjan@infradead.org> Cc: Ingo Molnar <mingo@elte.hu> Cc: Zach Brown <zach.brown@oracle.com>, Signed-off-by: Roland Dreier <rolandd@cisco.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/char_dev.c')
0 files changed, 0 insertions, 0 deletions