diff options
| author | Jesper Dangaard Brouer | 2014-03-03 14:45:39 +0100 |
|---|---|---|
| committer | Pablo Neira Ayuso | 2014-03-07 11:40:47 +0100 |
| commit | e1b207dac13ddb2f8ddebc7dc9729a97421909bd (patch) | |
| tree | 971503a1e212f5f42b3e50d9540c9ee409bf30fd /fs/dcookies.c | |
| parent | netfilter: conntrack: spinlock per cpu to protect special lists. (diff) | |
| download | kernel-qcow2-linux-e1b207dac13ddb2f8ddebc7dc9729a97421909bd.tar.gz kernel-qcow2-linux-e1b207dac13ddb2f8ddebc7dc9729a97421909bd.tar.xz kernel-qcow2-linux-e1b207dac13ddb2f8ddebc7dc9729a97421909bd.zip | |
netfilter: avoid race with exp->master ct
Preparation for disconnecting the nf_conntrack_lock from the
expectations code. Once the nf_conntrack_lock is lifted, a race
condition is exposed.
The expectations master conntrack exp->master, can race with
delete operations, as the refcnt increment happens too late in
init_conntrack(). Race is against other CPUs invoking
->destroy() (destroy_conntrack()), or nf_ct_delete() (via timeout
or early_drop()).
Avoid this race in nf_ct_find_expectation() by using atomic_inc_not_zero(),
and checking if nf_ct_is_dying() (path via nf_ct_delete()).
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'fs/dcookies.c')
0 files changed, 0 insertions, 0 deletions