diff options
| author | Oleg Nesterov | 2008-07-25 10:47:44 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2008-07-25 19:53:40 +0200 |
| commit | b564daf806d492dd4f7afe9b6c83b8d35d137669 (patch) | |
| tree | fbd6d186035b9a0a270fca97887da5d6b106a60c /fs/exec.c | |
| parent | coredump: make mm->core_state visible to ->core_dump() (diff) | |
| download | kernel-qcow2-linux-b564daf806d492dd4f7afe9b6c83b8d35d137669.tar.gz kernel-qcow2-linux-b564daf806d492dd4f7afe9b6c83b8d35d137669.tar.xz kernel-qcow2-linux-b564daf806d492dd4f7afe9b6c83b8d35d137669.zip | |
coredump: construct the list of coredumping threads at startup time
binfmt->core_dump() has to iterate over the all threads in system in order
to find the coredumping threads and construct the list using the
GFP_ATOMIC allocations.
With this patch each thread allocates the list node on exit_mm()'s stack and
adds itself to the list.
This allows us to do further changes:
- simplify ->core_dump()
- change exit_mm() to clear ->mm first, then wait for ->core_done.
this makes the coredumping process visible to oom_kill
- kill mm->core_done
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/exec.c')
| -rw-r--r-- | fs/exec.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/exec.c b/fs/exec.c index b8ee842d93cd..fe2873b8037f 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1604,6 +1604,8 @@ static int coredump_wait(int exit_code, struct core_state *core_state) init_completion(&mm->core_done); init_completion(&core_state->startup); + core_state->dumper.task = tsk; + core_state->dumper.next = NULL; core_waiters = zap_threads(tsk, mm, core_state, exit_code); up_write(&mm->mmap_sem); |