summaryrefslogtreecommitdiffstats
path: root/fs/ext4/balloc.c
diff options
context:
space:
mode:
authorEric Sandeen2009-02-26 06:57:35 +0100
committerTheodore Ts'o2009-02-26 06:57:35 +0100
commit8f64b32eb73fbfe9f38c4123121b63ee409278a7 (patch)
tree1c856ed32d7a282dbde0cea2e8839e2c2de51ba9 /fs/ext4/balloc.c
parentext4: Reorder fs/Makefile so that ext2 root fs's are mounted using ext2 (diff)
downloadkernel-qcow2-linux-8f64b32eb73fbfe9f38c4123121b63ee409278a7.tar.gz
kernel-qcow2-linux-8f64b32eb73fbfe9f38c4123121b63ee409278a7.tar.xz
kernel-qcow2-linux-8f64b32eb73fbfe9f38c4123121b63ee409278a7.zip
ext4: don't call jbd2_journal_force_commit_nested without journal
Running without a journal, I oopsed when I ran out of space, because we called jbd2_journal_force_commit_nested() from ext4_should_retry_alloc() without a journal. This should take care of it, I think. Signed-off-by: Eric Sandeen <sandeen@redhat.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/balloc.c')
-rw-r--r--fs/ext4/balloc.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 9a50b8052dcf..de9459b4cb94 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -609,7 +609,9 @@ int ext4_claim_free_blocks(struct ext4_sb_info *sbi,
*/
int ext4_should_retry_alloc(struct super_block *sb, int *retries)
{
- if (!ext4_has_free_blocks(EXT4_SB(sb), 1) || (*retries)++ > 3)
+ if (!ext4_has_free_blocks(EXT4_SB(sb), 1) ||
+ (*retries)++ > 3 ||
+ !EXT4_SB(sb)->s_journal)
return 0;
jbd_debug(1, "%s: retrying operation after ENOSPC\n", sb->s_id);