diff options
| author | Eric Biggers | 2017-04-30 05:27:26 +0200 |
|---|---|---|
| committer | Theodore Ts'o | 2017-04-30 05:27:26 +0200 |
| commit | 1bc0af600b011dbbf9bbf39664b858ea2e365729 (patch) | |
| tree | fd59ad97664de94f429398d0557aa7289d19fc24 /fs/ext4/ext4.h | |
| parent | jbd2: fix dbench4 performance regression for 'nobarrier' mounts (diff) | |
| download | kernel-qcow2-linux-1bc0af600b011dbbf9bbf39664b858ea2e365729.tar.gz kernel-qcow2-linux-1bc0af600b011dbbf9bbf39664b858ea2e365729.tar.xz kernel-qcow2-linux-1bc0af600b011dbbf9bbf39664b858ea2e365729.zip | |
ext4: trim return value and 'dir' argument from ext4_insert_dentry()
In the initial implementation of ext4 encryption, the filename was
encrypted in ext4_insert_dentry(), which could fail and also required
access to the 'dir' inode. Since then ext4 filename encryption has been
changed to encrypt the filename earlier, so we can revert the additions
to ext4_insert_dentry().
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/ext4.h')
| -rw-r--r-- | fs/ext4/ext4.h | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index fb69ee2388db..deb36ece85bf 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2356,11 +2356,10 @@ extern int ext4_find_dest_de(struct inode *dir, struct inode *inode, void *buf, int buf_size, struct ext4_filename *fname, struct ext4_dir_entry_2 **dest_de); -int ext4_insert_dentry(struct inode *dir, - struct inode *inode, - struct ext4_dir_entry_2 *de, - int buf_size, - struct ext4_filename *fname); +void ext4_insert_dentry(struct inode *inode, + struct ext4_dir_entry_2 *de, + int buf_size, + struct ext4_filename *fname); static inline void ext4_update_dx_flag(struct inode *inode) { if (!ext4_has_feature_dir_index(inode->i_sb)) |