diff options
| author | Aneesh Kumar K.V | 2009-01-06 03:49:55 +0100 |
|---|---|---|
| committer | Theodore Ts'o | 2009-01-06 03:49:55 +0100 |
| commit | 2ccb5fb9f113dae969d1ae9b6c10e80fa34f8cd3 (patch) | |
| tree | d9dc5bca94748d4173a7783e963d20b5a75f8db8 /fs/ext4/ext4.h | |
| parent | ext4: Fix the race between read_inode_bitmap() and ext4_new_inode() (diff) | |
| download | kernel-qcow2-linux-2ccb5fb9f113dae969d1ae9b6c10e80fa34f8cd3.tar.gz kernel-qcow2-linux-2ccb5fb9f113dae969d1ae9b6c10e80fa34f8cd3.tar.xz kernel-qcow2-linux-2ccb5fb9f113dae969d1ae9b6c10e80fa34f8cd3.zip | |
ext4: Use new buffer_head flag to check uninit group bitmaps initialization
For uninit block group, the on-disk bitmap is not initialized. That
implies we cannot depend on the uptodate flag on the bitmap
buffer_head to find bitmap validity. Use a new buffer_head flag which
would be set after we properly initialize the bitmap. This also
prevents (re-)initializing the uninit group bitmap every time we call
ext4_read_block_bitmap().
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
Diffstat (limited to 'fs/ext4/ext4.h')
| -rw-r--r-- | fs/ext4/ext4.h | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index ec862f4ca89f..695b45cc34e7 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -19,6 +19,7 @@ #include <linux/types.h> #include <linux/blkdev.h> #include <linux/magic.h> +#include <linux/jbd2.h> #include "ext4_i.h" /* @@ -1352,6 +1353,23 @@ extern int ext4_get_blocks_wrap(handle_t *handle, struct inode *inode, extern int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, __u64 start, __u64 len); +/* + * Add new method to test wether block and inode bitmaps are properly + * initialized. With uninit_bg reading the block from disk is not enough + * to mark the bitmap uptodate. We need to also zero-out the bitmap + */ +#define BH_BITMAP_UPTODATE BH_JBDPrivateStart + +static inline int bitmap_uptodate(struct buffer_head *bh) +{ + return (buffer_uptodate(bh) && + test_bit(BH_BITMAP_UPTODATE, &(bh)->b_state)); +} +static inline void set_bitmap_uptodate(struct buffer_head *bh) +{ + set_bit(BH_BITMAP_UPTODATE, &(bh)->b_state); +} + #endif /* __KERNEL__ */ #endif /* _EXT4_H */ |