summaryrefslogtreecommitdiffstats
path: root/fs/ext4/ext4.h
diff options
context:
space:
mode:
authorLukas Czerner2015-04-03 16:46:58 +0200
committerTheodore Ts'o2015-04-03 16:46:58 +0200
commite12fb97222fc41e8442896934f76d39ef99b590a (patch)
tree5325c812dee98b42b4e5bdc7e3f3e827d024f5b9 /fs/ext4/ext4.h
parentext4: don't release reserved space for previously allocated cluster (diff)
downloadkernel-qcow2-linux-e12fb97222fc41e8442896934f76d39ef99b590a.tar.gz
kernel-qcow2-linux-e12fb97222fc41e8442896934f76d39ef99b590a.tar.xz
kernel-qcow2-linux-e12fb97222fc41e8442896934f76d39ef99b590a.zip
ext4: make fsync to sync parent dir in no-journal for real this time
Previously commit 14ece1028b3ed53ffec1b1213ffc6acaf79ad77c added a support for for syncing parent directory of newly created inodes to make sure that the inode is not lost after a power failure in no-journal mode. However this does not work in majority of cases, namely: - if the directory has inline data - if the directory is already indexed - if the directory already has at least one block and: - the new entry fits into it - or we've successfully converted it to indexed So in those cases we might lose the inode entirely even after fsync in the no-journal mode. This also includes ext2 default mode obviously. I've noticed this while running xfstest generic/321 and even though the test should fail (we need to run fsck after a crash in no-journal mode) I could not find a newly created entries even when if it was fsynced before. Fix this by adjusting the ext4_add_entry() successful exit paths to set the inode EXT4_STATE_NEWENTRY so that fsync has the chance to fsync the parent directory as well. Signed-off-by: Lukas Czerner <lczerner@redhat.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Reviewed-by: Jan Kara <jack@suse.cz> Cc: Frank Mayhar <fmayhar@google.com> Cc: stable@vger.kernel.org
Diffstat (limited to 'fs/ext4/ext4.h')
0 files changed, 0 insertions, 0 deletions